From 91a2894911fdcb2a393040c803a89e7caf890fea Mon Sep 17 00:00:00 2001
From: michael <michael@modernfreedom.com>
Date: Mon, 22 Dec 2025 11:09:50 -0600
Subject: [PATCH] fix radio button state not updating in new job form
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The setValueAs transformation wasn't working correctly with radio
buttons in react-hook-form, causing the form value to remain a string
instead of being converted to a boolean. This caused Zod validation
to fail silently since the schema expects a boolean.

Fixed by using controlled radio buttons with explicit onChange handlers
that call setValue() with the proper boolean value.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 frontend/src/routes/jobs/NewJob.tsx | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/frontend/src/routes/jobs/NewJob.tsx b/frontend/src/routes/jobs/NewJob.tsx
index 08949fa..1f35bad 100644
--- a/frontend/src/routes/jobs/NewJob.tsx
+++ b/frontend/src/routes/jobs/NewJob.tsx
@@ -245,8 +245,9 @@ export function NewJob() {
             <label className="flex items-center">
               <input
                 type="radio"
-                {...register('sourceIsEnglish', { setValueAs: (v) => v === 'true' || v === true })}
-                value="true"
+                name="sourceIsEnglish"
+                checked={sourceIsEnglish === true}
+                onChange={() => setValue('sourceIsEnglish', true)}
                 className="mr-2"
               />
               <span>English</span>
@@ -254,8 +255,9 @@ export function NewJob() {
             <label className="flex items-center">
               <input
                 type="radio"
-                {...register('sourceIsEnglish', { setValueAs: (v) => v === 'true' || v === true })}
-                value="false"
+                name="sourceIsEnglish"
+                checked={sourceIsEnglish === false}
+                onChange={() => setValue('sourceIsEnglish', false)}
                 className="mr-2"
               />
               <span>Different language (auto-detect)</span>