From eaa12be728e3bb139e85b493509595672fdc6008 Mon Sep 17 00:00:00 2001
From: SamoilenkoVadym <samoylenko.vadym@gmail.comm>
Date: Mon, 9 Feb 2026 21:45:29 +0000
Subject: [PATCH] Fix MSAL.js load order: use onload callback

Define initMsal() first, then load CDN script with onload="initMsal()".
Prevents 'msal is not defined' race condition.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 templates/login.html | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/templates/login.html b/templates/login.html
index 988b937..a274d70 100644
--- a/templates/login.html
+++ b/templates/login.html
@@ -301,13 +301,16 @@
     </div>
 
     {% if sso_enabled %}
-    <script src="https://alcdn.msauth.net/browser/2.38.3/js/msal-browser.min.js"></script>
     <script>
         let msalInstance = null;
         let msalReady = false;
 
-        // Initialize MSAL asynchronously after script loads
-        (async function initMsal() {
+        // Called after MSAL.js CDN script loads
+        async function initMsal() {
+            if (typeof msal === 'undefined') {
+                console.error("MSAL library not loaded");
+                return;
+            }
             try {
                 const msalConfig = {
                     auth: {
@@ -326,7 +329,7 @@
             } catch (err) {
                 console.error("MSAL init failed:", err);
             }
-        })();
+        }
 
         async function loginWithMicrosoft() {
             const btn = document.getElementById('ssoBtn');
@@ -373,6 +376,7 @@
             }
         }
     </script>
+    <script src="https://alcdn.msauth.net/browser/2.38.3/js/msal-browser.min.js" onload="initMsal()" onerror="console.error('Failed to load MSAL.js from CDN')"></script>
     {% endif %}
 </body>
 </html>