From d07f8f05f6ede1a3cd5e62a969178dab720b958e Mon Sep 17 00:00:00 2001 From: sudipnext Date: Wed, 22 Apr 2026 12:50:21 +0545 Subject: [PATCH] fix: update placeholder image paths to use a consistent placeholder.jpg across image generation service and tests --- servers/fastapi/services/image_generation_service.py | 6 +++--- servers/fastapi/tests/test_image_generation.py | 6 +++--- servers/fastapi/tests/test_slide_to_html.py | 2 +- servers/fastapi/utils/process_slides.py | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/servers/fastapi/services/image_generation_service.py b/servers/fastapi/services/image_generation_service.py index c7f06bd9..ae8052dc 100644 --- a/servers/fastapi/services/image_generation_service.py +++ b/servers/fastapi/services/image_generation_service.py @@ -74,11 +74,11 @@ class ImageGenerationService: """ if self.is_image_generation_disabled: print("Image generation is disabled. Using placeholder image.") - return "/static/images/replaceable_template_image.png" + return "/static/images/placeholder.jpg" if not self.image_gen_func: print("No image generation function found. Using placeholder image.") - return "/static/images/replaceable_template_image.png" + return "/static/images/placeholder.jpg" image_prompt = prompt.get_image_prompt( with_theme=not self.is_stock_provider_selected() @@ -112,7 +112,7 @@ class ImageGenerationService: except Exception as e: print(f"Error generating image: {e}") - return "/static/images/replaceable_template_image.png" + return "/static/images/placeholder.jpg" async def generate_image_openai( self, prompt: str, output_directory: str, model: str, quality: str diff --git a/servers/fastapi/tests/test_image_generation.py b/servers/fastapi/tests/test_image_generation.py index 1c82f8d8..56a602b4 100644 --- a/servers/fastapi/tests/test_image_generation.py +++ b/servers/fastapi/tests/test_image_generation.py @@ -195,7 +195,7 @@ class TestImageGenerationService: result = await service.generate_image(sample_image_prompt) # Should return placeholder - assert result == "/static/images/replaceable_template_image.png" + assert result == "/static/images/placeholder.jpg" asyncio.run(run_test()) @@ -221,7 +221,7 @@ class TestImageGenerationService: result = await service.generate_image(sample_image_prompt) - assert result == "/static/images/replaceable_template_image.png" + assert result == "/static/images/placeholder.jpg" asyncio.run(run_test()) @@ -367,7 +367,7 @@ class TestImageGenerationEndpoint: with patch('api.v1.ppt.endpoints.images.get_images_directory', return_value=mock_images_directory): with patch('api.v1.ppt.endpoints.images.ImageGenerationService') as mock_service_class: mock_service_instance = Mock() - mock_service_instance.generate_image = AsyncMock(return_value="/static/images/replaceable_template_image.png") + mock_service_instance.generate_image = AsyncMock(return_value="/static/images/placeholder.jpg") mock_service_class.return_value = mock_service_instance response = client.get(f"/images/generate?prompt={test_prompt}") diff --git a/servers/fastapi/tests/test_slide_to_html.py b/servers/fastapi/tests/test_slide_to_html.py index 6aefdae3..330c5046 100644 --- a/servers/fastapi/tests/test_slide_to_html.py +++ b/servers/fastapi/tests/test_slide_to_html.py @@ -42,7 +42,7 @@ def test_slide_to_html_endpoint(): # Use a placeholder image path (since we can't easily test with real files) test_data = { - "image": "/static/images/replaceable_template_image.png", + "image": "/static/images/placeholder.jpg", "xml": test_xml } diff --git a/servers/fastapi/utils/process_slides.py b/servers/fastapi/utils/process_slides.py index 9048ff68..616d4efb 100644 --- a/servers/fastapi/utils/process_slides.py +++ b/servers/fastapi/utils/process_slides.py @@ -200,7 +200,7 @@ def process_slide_add_placeholder_assets(slide: SlideModel): for image_path in image_paths: image_dict = get_dict_at_path(slide.content, image_path) # Use FastAPI static path for placeholder image - image_dict["__image_url__"] = "/static/images/replaceable_template_image.png" + image_dict["__image_url__"] = "/static/images/placeholder.jpg" set_dict_at_path(slide.content, image_path, image_dict) for icon_path in icon_paths: