Oliver/presenton
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(api/read-file):uncontrolled data use & remove(supporting doc): unused images logic

Browse source
This commit is contained in:
shiva raj badu 2025-07-12 00:28:21 +05:45
parent 8a683306b8
commit 935e618982
3 changed files with 8 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
servers/nextjs/app/(presentation-generator)/upload/components/SupportingDoc.tsx
View file

@ -1,7 +1,7 @@
'use client'
import React, { useRef, useState } from 'react'
import { File, X, Upload, Image } from 'lucide-react'
import { File, X, Upload } from 'lucide-react'
import { useToast } from '@/hooks/use-toast'
import { cn } from '@/lib/utils'
@ -117,9 +117,6 @@ const SupportingDoc = ({ files, onFilesChange }: SupportingDocProps) => {
onFilesChange(updatedFiles)
}
const isImageFile = (file: File): boolean => {
return file.type?.startsWith('image/') || false
}
return (
<div className="w-full">
@ -186,11 +183,7 @@ const SupportingDoc = ({ files, onFilesChange }: SupportingDocProps) => {
</div>
<div data-testid="file-list" className="grid grid-cols-2 md:grid-cols-3 lg:grid-cols-5 gap-3">
{filesWithIds.map((file) => {
const isImage = isImageFile(file);
let imageUrl = '';
if (isImage) {
imageUrl = URL.createObjectURL(file);
}
return (
(
<div key={file.id}
@ -200,11 +193,9 @@ const SupportingDoc = ({ files, onFilesChange }: SupportingDocProps) => {
<div className="p-4 bg-purple-50 group-hover:bg-purple-100
transition-colors flex items-center justify-center relative"
>
{isImage ? (
<img src={imageUrl} className="w-10 h-10 text-purple-600" />
) : (
<File className="w-8 h-8 text-purple-600" />
)}
<File className="w-8 h-8 text-purple-600" />
<button
onClick={(e) => {
e.stopPropagation()

4
servers/nextjs/app/api/read-file/route.ts
View file

@ -11,9 +11,9 @@ export async function POST(request: Request) {
process.env.TEMP_DIRECTORY || '/tmp',
'/app/user_data'
];
const resolvedPath = path.resolve(normalizedPath);
const resolvedPath = fs.realpathSync(path.resolve(normalizedPath));
const isPathAllowed = allowedBaseDirs.some(baseDir => {
const resolvedBaseDir = path.resolve(baseDir);
const resolvedBaseDir = fs.realpathSync(path.resolve(baseDir));
return resolvedPath.startsWith(resolvedBaseDir + path.sep) || resolvedPath === resolvedBaseDir;
});

2
servers/nextjs/app/api/slide-metadata/route.ts
View file

@ -105,7 +105,7 @@ export async function POST(request: NextRequest) {
await page.setViewport({ width: 1440, height: 900, deviceScaleFactor: 1 });
try {
await page.goto(`http://localhost/presentation?id=${id}`, {
await page.goto(`http://localhost/pdf-maker?id=${id}`, {
waitUntil: "networkidle0",
timeout: 60000,
});