Oliver/modcomms
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix KB distillation fallback and SpecVersion type annotation

Browse source 
- knowledge_base_service.py: wrap Gemini distillation call in try/except
  to fall back to fallback_client/fallback_model if primary times out,
  matching the fallback behaviour in GeminiService._generate_content()

- models.py: fix SpecVersion.source_document_ids ORM type annotation from
  Mapped[Optional[dict]] to Mapped[Optional[list]] — the field stores a
  JSON array of document ID strings, not an object

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Vadym Samoilenko 2026-03-16 14:03:25 +00:00
parent 060fbeba76
commit f520aba397
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
backend/app/models/models.py
View file

@ -261,7 +261,7 @@ class SpecVersion(Base):
)
version_number: Mapped[int] = mapped_column(Integer, nullable=False)
content: Mapped[str] = mapped_column(Text, nullable=False)
source_document_ids: Mapped[Optional[dict]] = mapped_column(JSONB, nullable=True)
source_document_ids: Mapped[Optional[list]] = mapped_column(JSONB, nullable=True)
generated_by_id: Mapped[Optional[uuid.UUID]] = mapped_column(UUID(as_uuid=True), ForeignKey("users.id"), nullable=True)
generated_by_name: Mapped[Optional[str]] = mapped_column(String(255), nullable=True)
processing_job_id: Mapped[Optional[uuid.UUID]] = mapped_column(

15
backend/app/services/knowledge_base_service.py
View file

@ -292,10 +292,17 @@ class KnowledgeBaseService:
prompt = prompt_template.format(combined_markdown=combined_markdown)
logger.info(f"[KB_SERVICE] Sending {len(combined_markdown)} chars to Gemini for distillation")
response = await self.gemini.primary_client.aio.models.generate_content(
model=self.gemini.model,
contents=prompt,
)
try:
response = await self.gemini.primary_client.aio.models.generate_content(
model=self.gemini.model,
contents=prompt,
)
except Exception as e:
logger.warning(f"[KB_SERVICE] Primary model failed: {e}. Retrying with fallback.")
response = await self.gemini.fallback_client.aio.models.generate_content(
model=self.gemini.fallback_model,
contents=prompt,
)
spec_content = response.text.strip()
logger.info(f"[KB_SERVICE] Distillation complete: {len(spec_content)} chars")