Issue: Email body showed {campaign_name} instead of actual values
Cause: HTML templates used {variable} (Python format) but rendered with Jinja2
Fix: Changed all HTML template variables to {{ variable }} (Jinja2 syntax)
Templates Fixed:
- a1_to_a2_complete: {{ campaign_name }}, {{ campaign_id }}, {{ campaign_number }}, {{ asset_count }}
- a2_to_a3_complete: {{ campaign_name }}, {{ campaign_id }}, {{ asset_count }}
- upload_failed: {{ filename }}, {{ tracking_id }}, {{ error }}
- a1_to_a2_partial: {{ campaign_name }}, {{ campaign_id }}, {{ total_assets }}, {{ successful }}, {{ failed }}
Note: Subject lines use {variable} (Python .format()) which is correct
HTML bodies use {{ variable }} (Jinja2) which is now correct
Email notifications will now display all values properly!
🤖 Generated with Claude Code
185 lines
7.3 KiB
Python
185 lines
7.3 KiB
Python
"""
|
|
Notifier - Email and Webhook Notifications
|
|
Handles SMTP emails (Mailgun) and outgoing webhooks
|
|
Compatible with Python 3.6+
|
|
"""
|
|
|
|
import requests
|
|
import logging
|
|
import smtplib
|
|
from email.mime.text import MIMEText
|
|
from email.mime.multipart import MIMEMultipart
|
|
from jinja2 import Template
|
|
|
|
logger = logging.getLogger('Notifier')
|
|
|
|
class Notifier:
|
|
def __init__(self, config):
|
|
self.config = config
|
|
self.enabled = config['notifications']['enabled']
|
|
|
|
# SMTP configuration (preferred method)
|
|
smtp_config = config['notifications'].get('smtp', {})
|
|
self.smtp_server = smtp_config.get('server')
|
|
self.smtp_port = smtp_config.get('port', 587)
|
|
self.smtp_user = smtp_config.get('user')
|
|
self.smtp_password = smtp_config.get('password')
|
|
self.sender_email = smtp_config.get('sender_email')
|
|
|
|
self.recipients = config['notifications']['recipients']
|
|
self.webhook_config = config.get('webhooks', {})
|
|
|
|
def send_email(self, template_name, recipients, data):
|
|
"""
|
|
Send email via SMTP (Mailgun)
|
|
|
|
Args:
|
|
template_name: Name of email template
|
|
recipients: List of email addresses or single email
|
|
data: Template data dict
|
|
"""
|
|
if not self.enabled:
|
|
logger.info("Notifications disabled, skipping email")
|
|
return
|
|
|
|
if not self.smtp_server or not self.smtp_user:
|
|
logger.warning("SMTP not configured, skipping email")
|
|
return
|
|
|
|
try:
|
|
# Simple templates (full template system would load from YAML)
|
|
templates = {
|
|
'a1_to_a2_complete': {
|
|
'subject': "✅ Master Assets Downloaded - Campaign {campaign_name}",
|
|
'html': """
|
|
<h2>Master Assets Downloaded Successfully</h2>
|
|
<p><strong>Campaign:</strong> {{ campaign_name }} ({{ campaign_id }})</p>
|
|
<p><strong>Campaign Number:</strong> {{ campaign_number }}</p>
|
|
<p><strong>Assets Downloaded:</strong> {{ asset_count }}</p>
|
|
<p><strong>Status Updated:</strong> A1 → A2</p>
|
|
<hr>
|
|
<p>All assets have been downloaded and uploaded to Box with tracking IDs.</p>
|
|
"""
|
|
},
|
|
'a2_to_a3_complete': {
|
|
'subject': "✅ Localized Assets Uploaded - Campaign {campaign_name}",
|
|
'html': """
|
|
<h2>Localized Assets Uploaded Successfully</h2>
|
|
<p><strong>Campaign:</strong> {{ campaign_name }}</p>
|
|
<p><strong>Campaign ID:</strong> {{ campaign_id }}</p>
|
|
<p><strong>Assets Uploaded:</strong> {{ asset_count }}</p>
|
|
<p><strong>Status Updated:</strong> A2 → A3</p>
|
|
<hr>
|
|
<p>All localized assets have been uploaded to DAM.</p>
|
|
"""
|
|
},
|
|
'upload_failed': {
|
|
'subject': "❌ Upload Failed - {filename}",
|
|
'html': """
|
|
<h2 style="color: red;">Upload Failed</h2>
|
|
<p><strong>Filename:</strong> {{ filename }}</p>
|
|
<p><strong>Tracking ID:</strong> {{ tracking_id }}</p>
|
|
<p><strong>Error:</strong> {{ error }}</p>
|
|
<hr>
|
|
<p>Please investigate the error.</p>
|
|
"""
|
|
},
|
|
'a1_to_a2_partial': {
|
|
'subject': "⚠️ Partial Download - Campaign {campaign_name}",
|
|
'html': """
|
|
<h2 style="color: orange;">Campaign Partially Processed</h2>
|
|
<p><strong>Campaign:</strong> {{ campaign_name }} ({{ campaign_id }})</p>
|
|
<p><strong>Total Assets:</strong> {{ total_assets }}</p>
|
|
<p><strong>Successful:</strong> {{ successful }}</p>
|
|
<p><strong>Failed:</strong> {{ failed }}</p>
|
|
<hr>
|
|
<p style="color: red;"><strong>Status NOT updated.</strong> Campaign remains at A1.</p>
|
|
<p>Please review failed assets and retry.</p>
|
|
"""
|
|
}
|
|
}
|
|
|
|
template_config = templates.get(template_name, {
|
|
'subject': 'Ferrero Automation Notification',
|
|
'html': '<p>{}</p>'.format(data)
|
|
})
|
|
|
|
# Render subject and body
|
|
subject = template_config['subject'].format(**data)
|
|
html_template = Template(template_config['html'])
|
|
html_body = html_template.render(**data)
|
|
|
|
# Prepare email
|
|
msg = MIMEMultipart('alternative')
|
|
msg['Subject'] = subject
|
|
msg['From'] = self.sender_email
|
|
msg['To'] = ', '.join(recipients) if isinstance(recipients, list) else recipients
|
|
|
|
# Attach HTML body
|
|
html_part = MIMEText(html_body, 'html')
|
|
msg.attach(html_part)
|
|
|
|
# Send via SMTP
|
|
with smtplib.SMTP(self.smtp_server, self.smtp_port) as server:
|
|
server.starttls()
|
|
server.login(self.smtp_user, self.smtp_password)
|
|
server.send_message(msg)
|
|
|
|
logger.info("Email sent via SMTP: {} to {}".format(template_name, recipients))
|
|
|
|
except Exception as e:
|
|
logger.error("Email error: {}".format(str(e)))
|
|
|
|
def send_webhook(self, url, payload):
|
|
"""
|
|
Send outgoing webhook notification
|
|
|
|
Args:
|
|
url: Webhook URL
|
|
payload: dict to send as JSON
|
|
|
|
Returns:
|
|
bool: Success status
|
|
"""
|
|
try:
|
|
# Get webhook config if exists
|
|
webhook_config = None
|
|
for name, config in self.webhook_config.items():
|
|
if config.get('url') == url:
|
|
webhook_config = config
|
|
break
|
|
|
|
if not webhook_config:
|
|
webhook_config = {'timeout_seconds': 10, 'auth': {}}
|
|
|
|
# Prepare headers
|
|
headers = {'Content-Type': 'application/json'}
|
|
|
|
# Add auth if configured
|
|
auth_config = webhook_config.get('auth', {})
|
|
if auth_config.get('type') == 'bearer' and auth_config.get('token'):
|
|
headers['Authorization'] = 'Bearer {}'.format(auth_config['token'])
|
|
elif auth_config.get('type') == 'basic':
|
|
# Could add basic auth here if needed
|
|
pass
|
|
|
|
# Send webhook
|
|
response = requests.post(
|
|
url,
|
|
json=payload,
|
|
headers=headers,
|
|
timeout=webhook_config.get('timeout_seconds', 10)
|
|
)
|
|
|
|
if response.status_code in [200, 201, 202]:
|
|
logger.info("Webhook sent successfully: {}".format(url))
|
|
return True
|
|
else:
|
|
logger.warning("Webhook failed: HTTP {} - {}".format(
|
|
response.status_code, response.text[:200]
|
|
))
|
|
return False
|
|
|
|
except Exception as e:
|
|
logger.error("Webhook error: {}".format(str(e)))
|
|
return False
|