Critical Fix:
- extract_global_campaign_reference() now accepts campaign_id parameter
- Always sets local_campaign_id to current campaign as fallback
- Prevents NULL local_campaign_id when no Global Campaign Reference exists
Root Cause:
- Assets without Global Campaign Reference had NULL local_campaign_id
- Caused derivatives to be linked to wrong campaigns
- Same asset in multiple campaigns would share tracking IDs incorrectly
Impact:
- Every asset now has proper local_campaign_id
- Derivatives correctly linked to their source campaign
- Fixes issue where C000001177 assets were showing as C000002098
Changes:
- database.py: Added campaign_id parameter with fallback logic
- a1_to_a2_box_uploader.py: Pass campaign_number to function
- a5_to_a6_download.py: Pass campaign_number to function
Critical fix and UX improvements for all workflow email notifications.
CRITICAL FIX:
- A5→A6 now correctly searches Final Assets folder (is_global=True)
- Previously searched Master Assets folder (wrong location)
- Now finds NOT APPROVED rework assets correctly
TESTED SUCCESSFULLY:
✓ Found 6 total assets in Final Assets folder
✓ Filtered 4 NOT APPROVED assets correctly
✓ Skipped 2 folders without ECOMMERCE STATUS field
✓ Downloaded and uploaded 4 assets to Box Revisions folder
✓ Email sent with rejection details
✓ Status updated A5→A6
EMAIL TEMPLATE STYLING UNIFICATION:
All templates now use consistent modern styling matching a5_to_a6_rejections:
- Colored header bars with centered titles
- Bordered info boxes with left accent bars
- Card-based asset display with colored headers
- Consistent spacing and typography
- Professional color scheme
Templates Updated:
1. a1_to_a2_complete - Green theme (#28a745)
2. a1_to_a2_partial - Orange theme (#ff9800)
3. a2_to_a3_complete - Green theme (#28a745)
4. a2_to_a3_file_uploaded - Green/Blue theme
5. b1_to_b2_complete - Blue theme (#1976d2)
6. b1_to_b2_partial - Orange theme (#ff9800)
7. upload_failed - Red theme (#d32f2f)
All templates keep existing data/functionality, only styling improved.
Color Scheme:
- Success: Green (#28a745)
- Warning/Partial: Orange (#ff9800)
- Error: Red (#d32f2f)
- Info: Blue (#1976d2)
- Highlights: Yellow (#ffc107)
Changes:
- Python-Version/scripts/a5_to_a6_download.py (is_global=True fix)
- Python-Version/scripts/shared/notifier.py (7 templates restyled)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Major enhancements to all workflow scripts with recursive search and detailed rejection tracking.
NEW FEATURES:
1. Recursive Folder Search (ALL workflows: A1→A2, A5→A6, B1→B2)
- Searches subfolders within Master/Final Assets folders
- Preserves folder structure in Box
- Adds 'folder_path' attribute to each asset
2. NOT APPROVED Filtering (A5→A6 ONLY)
- Only downloads assets with ECOMMERCE STATUS = "NOT APPROVED"
- Skips approved/other status assets
- Logs rejected vs skipped counts
3. Rejection Details Extraction (A5→A6)
- Extracts comments from 3 reviewers: Approver, Legal, IA&CC
- Includes certifier names and dates
- Displays in detailed email notifications
CHANGES BY FILE:
dam_client.py:
- NEW: _get_assets_recursive() - Recursively searches folders
- UPDATED: get_master_assets() - Now uses recursive search, adds folder_path to assets
- NEW: is_asset_not_approved() - Checks FERRERO.FIELD.ECOMMERCE STATUS
- NEW: extract_rejection_details() - Extracts all rejection comments from 10 fields
box_client.py:
- UPDATED: upload_with_tracking_id() - Added subfolder_path parameter
- NEW: _get_or_create_subfolder_path() - Creates/navigates Box subfolders
- Preserves DAM folder structure in Box uploads
a1_to_a2_download.py:
- Added folder_path extraction from assets
- Pass subfolder_path to Box upload
- Logs subfolder info during processing
b1_to_b2_download.py:
- Added folder_path extraction from assets
- Pass subfolder_path to Box upload
- Logs subfolder info during processing
a5_to_a6_download.py:
- Filter assets for NOT APPROVED status ONLY
- Extract rejection details for each asset
- Pass subfolder_path to Box upload
- Updated email data with rejection_details
- Handle "no rejections" scenario with email
- Updated logging to show rejected vs skipped counts
notifier.py:
- REPLACED: a5_to_a6_complete → a5_to_a6_rejections
- Detailed HTML template with rejection sections
- Shows Approver, Legal, and IA&CC rejections
- Styled with red warnings and bordered sections
- NEW: a5_to_a6_no_rejections template
- Green success message when no rejected assets found
- UPDATED: a5_to_a6_partial - Now uses rejected_assets
FIELD IDs EXTRACTED (A5→A6):
- FERRERO.FIELD.ECOMMERCE STATUS (primary check)
- FERRERO.MARKETING.FIELD.CERTIFIER COMMENT
- FERRERO.FIELD.ECOMMERCE CERTIFIER
- FERRERO.MARKETING.FIELD.APPROVAL DATE
- FERRERO.MARKETING.FIELD.LEGAL COMMENT
- FERRERO.FIELD.LEGAL CERTIFER (typo in field ID)
- FERRERO.MARKETING.FIELD.LEGAL APPROVAL DATE
- FERRERO.MARKETING.FIELD.IA CC COMMENT
- FERRERO.MARKETING.FIELD.IA CERTIFIER
- FERRERO.MARKETING.FIELD.IA CC APPROVAL DATE
TESTING:
✓ All connections working (DAM, Box, Database)
✓ A5→A6 script executes correctly
✓ Recursive search working
✓ NOT APPROVED filtering working
✓ "No rejections" email sent successfully
✓ Folder structure preserved in logs
WORKFLOW IMPACTS:
- A1→A2: Now searches recursively, preserves folder structure
- A5→A6: Filters for NOT APPROVED only, shows rejection details
- B1→B2: Now searches recursively, preserves folder structure
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
